Merge pull request #3733 from kuwarantine/channel-fix

Fix channel clip delay issue and channeled tick APL value
wowsims · Sep 23, 2023 · c8242e2 · c8242e2
2 parents 3120aea + 1954d36
commit c8242e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/sim/core/apl_values_spell.go b/sim/core/apl_values_spell.go
@@ -214,7 +214,7 @@ func (rot *APLRotation) newValueSpellChanneledTicks(config *proto.APLValueSpellC
 	}
 }
 func (value *APLValueSpellChanneledTicks) Type() proto.APLValueType {
-	return proto.APLValueType_ValueTypeBool
+	return proto.APLValueType_ValueTypeInt
 }
 func (value *APLValueSpellChanneledTicks) GetInt(sim *Simulation) int32 {
 	channeledDot := value.spell.Unit.ChanneledDot

diff --git a/ui/core/player.ts b/ui/core/player.ts
@@ -827,11 +827,11 @@ export class Player<SpecType extends Spec> {
 	}
 
 	getChannelClipDelay(): number {
-		return this.reactionTime;
+		return this.channelClipDelay;
 	}
 
 	setChannelClipDelay(eventID: EventID, newChannelClipDelay: number) {
-		if (newChannelClipDelay == this.reactionTime)
+		if (newChannelClipDelay == this.channelClipDelay)
 			return;
 
 		this.channelClipDelay = newChannelClipDelay;