Skip to content

Commit

Permalink
Merge pull request #3934 from wowsims/apl
Browse files Browse the repository at this point in the history
Fix panic when mixing Cast and Channel for channeled spells
  • Loading branch information
jimmyt857 authored Oct 22, 2023
2 parents b406014 + 65a1c07 commit da78d1c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions sim/core/apl.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,11 @@ func (apl *APLRotation) getNextAction(sim *Simulation) *APLAction {

func (apl *APLRotation) shouldInterruptChannel(sim *Simulation) bool {
channeledDot := apl.unit.ChanneledDot
if channeledDot == nil {
// Cast was started by a different APL action (not Channel) so is non-interruptible.
return false
}

if channeledDot.MaxTicksRemaining() == 0 {
// Channel has ended, but apl.unit.ChanneledDot hasn't been cleared yet meaning the aura is still active.
return false
Expand Down

0 comments on commit da78d1c

Please sign in to comment.