Fix dfo (#3819)

* fix DFO procmask * update tests
wowsims · Oct 5, 2023 · ed0c98d · ed0c98d
1 parent 7aa95b0
commit ed0c98d
Show file tree

Hide file tree

Showing 27 changed files with 499 additions and 499 deletions.
diff --git a/sim/common/wotlk/other_effects.go b/sim/common/wotlk/other_effects.go
@@ -492,7 +492,7 @@ func init() {
 
 			triggerAura := core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
 				Name:       name + " Trigger",
-				Callback:   core.CallbackOnSpellHitDealt,
+				Callback:   core.CallbackOnCastComplete,
 				ProcMask:   core.ProcMaskSpellOrProc,
 				Harmful:    true,
 				ProcChance: 0.10,

diff --git a/sim/deathknight/dps/TestBlood.results b/sim/deathknight/dps/TestBlood.results
@@ -245,8 +245,8 @@ dps_results: {
 dps_results: {
  key: "TestBlood-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 10509.9685
-  tps: 5304.35857
+  dps: 10510.12726
+  tps: 5304.48641
  }
 }
 dps_results: {

diff --git a/sim/deathknight/dps/TestFrost.results b/sim/deathknight/dps/TestFrost.results
@@ -252,15 +252,15 @@ dps_results: {
 dps_results: {
  key: "TestFrost-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 11033.84501
-  tps: 6455.27185
+  dps: 11032.7186
+  tps: 6456.40024
  }
 }
 dps_results: {
  key: "TestFrost-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 10979.60891
-  tps: 6422.94426
+  dps: 10982.65136
+  tps: 6424.86824
  }
 }
 dps_results: {

diff --git a/sim/deathknight/dps/TestFrostUH.results b/sim/deathknight/dps/TestFrostUH.results
@@ -252,15 +252,15 @@ dps_results: {
 dps_results: {
  key: "TestFrostUH-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 11141.8117
-  tps: 7924.62083
+  dps: 11160.77388
+  tps: 7938.63885
  }
 }
 dps_results: {
  key: "TestFrostUH-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 11148.59938
-  tps: 7930.97759
+  dps: 11142.00905
+  tps: 7926.61552
  }
 }
 dps_results: {

diff --git a/sim/deathknight/dps/TestUnholy.results b/sim/deathknight/dps/TestUnholy.results
@@ -278,16 +278,16 @@ dps_results: {
 dps_results: {
  key: "TestUnholy-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 11848.51542
-  tps: 7783.12992
+  dps: 11848.4543
+  tps: 7783.00499
   hps: 318.47988
  }
 }
 dps_results: {
  key: "TestUnholy-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 11780.95553
-  tps: 7717.55828
+  dps: 11780.58937
+  tps: 7717.35199
   hps: 317.21607
  }
 }

diff --git a/sim/deathknight/tank/TestBloodTank.results b/sim/deathknight/tank/TestBloodTank.results
@@ -252,15 +252,15 @@ dps_results: {
 dps_results: {
  key: "TestBloodTank-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 2167.25151
-  tps: 6589.41411
+  dps: 2167.45627
+  tps: 6589.92063
  }
 }
 dps_results: {
  key: "TestBloodTank-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 2153.84358
-  tps: 6574.13891
+  dps: 2153.58281
+  tps: 6575.72721
  }
 }
 dps_results: {

diff --git a/sim/druid/balance/TestBalance.results b/sim/druid/balance/TestBalance.results
@@ -221,15 +221,15 @@ dps_results: {
 dps_results: {
  key: "TestBalance-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 8127.95569
-  tps: 7904.36494
+  dps: 8140.23944
+  tps: 7915.87124
  }
 }
 dps_results: {
  key: "TestBalance-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 8088.47549
-  tps: 7866.38524
+  dps: 8088.72563
+  tps: 7870.09491
  }
 }
 dps_results: {

diff --git a/sim/druid/balance/TestBalancePhase3.results b/sim/druid/balance/TestBalancePhase3.results
@@ -221,15 +221,15 @@ dps_results: {
 dps_results: {
  key: "TestBalancePhase3-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 11620.1212
-  tps: 11327.85975
+  dps: 11645.4463
+  tps: 11352.54545
  }
 }
 dps_results: {
  key: "TestBalancePhase3-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 11488.75579
-  tps: 11196.80515
+  dps: 11500.20549
+  tps: 11206.91429
  }
 }
 dps_results: {

diff --git a/sim/druid/feral/TestFeral.results b/sim/druid/feral/TestFeral.results
@@ -224,15 +224,15 @@ dps_results: {
 dps_results: {
  key: "TestFeral-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 7578.87979
-  tps: 5443.75067
+  dps: 7576.55555
+  tps: 5442.10046
  }
 }
 dps_results: {
  key: "TestFeral-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 7585.83338
-  tps: 5448.61292
+  dps: 7586.15472
+  tps: 5448.84108
  }
 }
 dps_results: {

diff --git a/sim/druid/feral/TestFeralDoubleArmorPenTrinketsNoDesync.results b/sim/druid/feral/TestFeralDoubleArmorPenTrinketsNoDesync.results
@@ -224,15 +224,15 @@ dps_results: {
 dps_results: {
  key: "TestFeralDoubleArmorPenTrinketsNoDesync-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 9866.98628
-  tps: 7069.12893
+  dps: 9867.01454
+  tps: 7069.14899
  }
 }
 dps_results: {
  key: "TestFeralDoubleArmorPenTrinketsNoDesync-AllItems-DislodgedForeignObject-50353"
  value: {
-  dps: 9843.70145
-  tps: 7052.52191
+  dps: 9840.12642
+  tps: 7049.90885
  }
 }
 dps_results: {

diff --git a/sim/druid/feral/TestFeralDoubleArmorPenTrinketsWithDesync.results b/sim/druid/feral/TestFeralDoubleArmorPenTrinketsWithDesync.results
@@ -224,8 +224,8 @@ dps_results: {
 dps_results: {
  key: "TestFeralDoubleArmorPenTrinketsWithDesync-AllItems-DislodgedForeignObject-50348"
  value: {
-  dps: 9866.98628
-  tps: 7069.12893
+  dps: 9866.66647
+  tps: 7068.90186
  }
 }
 dps_results: {

diff --git a/sim/hunter/steady_shot.go b/sim/hunter/steady_shot.go
@@ -60,7 +60,7 @@ func (hunter *Hunter) registerSteadyShotSpell() {
 		Cast: core.CastConfig{
 			DefaultCast: core.Cast{
 				GCD:      core.GCDDefault,
-				CastTime: 1, // Dummy value so core doesn't optimize the cast away
+				CastTime: time.Millisecond * 2000,
 			},
 			ModifyCast: func(_ *core.Simulation, _ *core.Spell, cast *core.Cast) {
 				cast.CastTime = hunter.SteadyShotCastTime()