Merge pull request #3213 from Tharre/warlock_fixes

core: only roll for hit if we can actually miss
wowsims · Jun 26, 2023 · f90abaf · f90abaf
2 parents d2511a9 + 380ae35
commit f90abaf
Show file tree

Hide file tree

Showing 39 changed files with 6,035 additions and 6,035 deletions.
diff --git a/sim/core/spell_result.go b/sim/core/spell_result.go
@@ -128,7 +128,7 @@ func (spell *Spell) SpellChanceToMiss(attackTable *AttackTable) float64 {
 	return math.Max(0, attackTable.BaseSpellMissChance-spell.SpellHitChance(attackTable.Defender))
 }
 func (spell *Spell) MagicHitCheck(sim *Simulation, attackTable *AttackTable) bool {
-	return sim.RandomFloat("Magical Hit Roll") > spell.SpellChanceToMiss(attackTable)
+	return sim.Proc(1.0-spell.SpellChanceToMiss(attackTable), "Magical Hit Roll")
 }
 
 func (spell *Spell) spellCritRating(target *Unit) float64 {