Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict Sequence with Blood Tap doesn't work as expected #3548

Closed
blu3bird opened this issue Aug 22, 2023 · 2 comments · Fixed by #3606
Closed

Strict Sequence with Blood Tap doesn't work as expected #3548

blu3bird opened this issue Aug 22, 2023 · 2 comments · Fixed by #3606

Comments

@blu3bird
Copy link

I have this Strict Sequence:
Screenshot from 2023-08-22 22-55-17

I expect it to be executed if these conditions are met:

  • Blood Tap is not on cooldown
  • Ghoul Frenzy is not on cooldown

But instead it only executes if these conditions are met:

  • Blood Tap is not on cooldown
  • Ghoul Frenzy is not on cooldown
  • At least 1 unholy rune is available

Because Blood Tap will grant you one death rune immediately there is no need to wait for an unholy rune.

Steps to reproduce:

  • open the death knight sim
  • select whatever gear and settings you want (encounter duration must be at least 11 seconds)
  • select "Unholy DW SS" talents
  • select "Unholy DW SS APL" rotation
    • it has the Strict Sequence mentioned above in it
    • disable the Ghoul Frenzy Prepull Action
    • disable Autocast Other Cooldowns
    • disable Summon Gargoyle Priority
  • simulate
  • go to Results -> Timeline
    • Blood Tap/Ghoul Frenzy is execute at second 11 when it should be execute at second 4
@rosenrusinov
Copy link
Contributor

@jimmyt857 this ones an interesting one. I wonder if we should even do something about it. In practice strict sequences do have the requirements that all actions in the sequence can be executed before the sequence is started. Maybe we can have another type of strict sequence that would only check for the first action and then fail out if it goes to an action it cant cast?=

@jimmyt857
Copy link
Contributor

This is the same problem I was running into with warrior stance dancing, it's not possible to write a strict sequence like, "Battle Stance --> Thunderclap --> Berserker Stance" even though that would be the simplest and most intuitive way to accomplish the goal.

I suspect we want to solve this somehow, but I don't know the answer either. The first thing I'd like to know is, how would simc's APL accomplish this. If there is an established way of handling this then we can mimic them, otherwise we'll have to consider something like your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants