Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APL Crash: Rogue Cannot Cast Fan of Knives #3611

Closed
where-fore opened this issue Sep 4, 2023 · 0 comments · Fixed by #3612
Closed

APL Crash: Rogue Cannot Cast Fan of Knives #3611

where-fore opened this issue Sep 4, 2023 · 0 comments · Fixed by #3612

Comments

@where-fore
Copy link
Contributor

Adding a simple APL command of If <none>: Cast Fan of Knives crashes the sim in an infinite loop. I imagine it's referencing a subspell that doesn't exist, like the previous Blade Flurry issue.

A restore defaults on the live version with the following APL can reproduce the issue:
image

https://wowsims.github.io/wotlk/rogue/#eJzjEudgMmDKYCxgamBkXMHIuIOR8QIj4wtGRicBBSYLRgfGCMYCxg6wlBCD1AXWJka2gJzEytQiDkYBNqm1jFz8AtvOMEm8lFVi23aY6dcOJi4WgWd7mbjYBW5eZpJ4IAtkXFvLJDFVBqiwbSuTxA+gwsM7mM6dZeLiFZjQyyTRKqfEAhRgAHI7gPJTZJRYfoG4PALf9jKB1QIR0JSeZUwS72WBwv19TBLTZJSYD4Pt6toLJpeByDdg9t2bIOUPljNJnAXZvngZmMEicOcKkxIX0LOsASwRLAksi5i+MnEdYGIYBRQBIQNSdVSxcDBKMEWpAaOSSYJJAZj6LFgcWKTEgDxGBRGD/zDA6Hr2zBnbLkZNAwNTYwNjQwMTY1MjQyDHyMDQwNgYKGBqqAvkgpGxrqmB0SNGHo4TT5kEjj9lkjj4lOkFI8sHRvZZjAyHmPgXAJMvlxSHFBsXC0f3FOYTTCcYbzEyzGJiUOpm5gQ7qyHNQRDiQBEHyVkzQeCkvSVE5IK9YhoYXLM3us2kECzBqkXjlKPR6UANYxpOHiFgTjBV7CEHQMJ273sHRwj/h30CYxA4T9pyXV9cYPvJ/vBXjZj+Q3/tiTWxWmSd+8OqLfZvAnfItb6+iEPfB3uI+d/s5VtfA1V+tQfpEln33R5Euj98ZQ+0FGjze6LtHWxAyADssVZ2B0g6ZnYgpCMKmos/EO1nAJlpsjg=

Infinite loop detected, current action:
ACTION = Cast Spell(Fan of Knives)
Stack Trace:
goroutine 15 [running]:
runtime/debug.Stack()
/opt/hostedtoolcache/go/1.18.10/x64/src/runtime/debug/stack.go:24 +0x6
github.com/wowsims/wotlk/sim/core.runSim.func1()
/home/runner/work/wotlk/wotlk/sim/core/sim.go:61 +0x10
panic({0xed740, 0x1bda760})
/opt/hostedtoolcache/go/1.18.10/x64/src/runtime/panic.go:838 +0x29
github.com/wowsims/wotlk/sim/core.(*APLRotation).DoNextAction(0x2479400, 0x2412fd0)
/home/runner/work/wotlk/wotlk/sim/core/apl.go:165 +0x3a
github.com/wowsims/wotlk/sim/core.(*AutoAttacks).TrySwingMH(0x24b6d50, 0x2412fd0, 0x2482800)
/home/runner/work/wotlk/wotlk/sim/core/attack.go:511 +0x28
github.com/wowsims/wotlk/sim/core.(*AutoAttacks).SwingMelee(0x24b6d50, 0x2412fd0, 0x2482800)
/home/runner/work/wotlk/wotlk/sim/core/attack.go:489 +0x2
github.com/wowsims/wotlk/sim/core.(*AutoAttacks).resetAutoSwing.func1(0x2412fd0)
/home/runner/work/wotlk/wotlk/sim/core/attack.go:414 +0x6
github.com/wowsims/wotlk/sim/core.(*Simulation).Step(0x2412fd0, 0x7fffffffffffffff)
/home/runner/work/wotlk/wotlk/sim/core/sim.go:426 +0x22
github.com/wowsims/wotlk/sim/core.(*Simulation).runPendingActions(...)
/home/runner/work/wotlk/wotlk/sim/core/sim.go:330
github.com/wowsims/wotlk/sim/core.(*Simulation).runOnce(0x2412fd0)
/home/runner/work/wotlk/wotlk/sim/core/sim.go:388 +0x9
github.com/wowsims/wotlk/sim/core.(*Simulation).run(0x2412fd0)
/home/runner/work/wotlk/wotlk/sim/core/sim.go:280 +0x11
github.com/wowsims/wotlk/sim/core.runSim(0x2495b00, 0x1bd8fc0, 0x0)
/home/runner/work/wotlk/wotlk/sim/core/sim.go:115 +0x3b
github.com/wowsims/wotlk/sim/core.RunSim(0x2495b00, 0x1bd8fc0)
/home/runner/work/wotlk/wotlk/sim/core/sim.go:47 +0x2
created by github.com/wowsims/wotlk/sim/core.RunRaidSimAsync
/home/runner/work/wotlk/wotlk/sim/core/api.go:52 +0x8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant