Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerubian Leg Reinforcements - alert shown even though it works in game. #3879

Closed
BorniPL opened this issue Oct 14, 2023 · 2 comments
Closed

Comments

@BorniPL
Copy link

BorniPL commented Oct 14, 2023

Describe the bug
Shows alert "Nerubian Leg Reinforcements requires Leatherworking, but it is not selected.".
You don't have to have Leatherworking in order for this enhancement to work.
I swapped off Leatherworking few days ago.
The wrist enhancement - yes, for this you have to have Leatherworking for it to work.

To Reproduce
Steps to reproduce the behavior:

  1. Be Leatherworker
  2. Put "Nerubian Leg Reinforcements" on your leg piece
  3. Swap off leatherworking
  4. The enhancement still works

Expected behavior
It shouldn't show an error for this enhancement.

Sim Links and Screenshots
image
image

Desktop (please complete the following information):

  • OS: Windows 10 2009
  • Browser: Firefox
  • Version: 118.0.2
@BorniPL BorniPL changed the title Nerubian Leg Reinforcements - error shown even though it works in game. Nerubian Leg Reinforcements - alert shown even though it works in game. Oct 14, 2023
@jarveson
Copy link
Contributor

warning maybe could be rephrased but theres no way to detect someone that 'actually' has the enchant vs someone that applied the enchant but then swapped off the profession. the amount of people doing that is prolly low enough as well to where this shouldnt be that bad of an issue

@BorniPL
Copy link
Author

BorniPL commented Oct 17, 2023

For this particular enhancement you could drop the profession check - the stats are the same as the enhancement that does not require being LW to apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants