Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Addon Import' modal fails to complete action upon interaction with 'Import' primary button after pasting in code from Addon #3888

Closed
xonkz opened this issue Oct 16, 2023 · 1 comment

Comments

@xonkz
Copy link

xonkz commented Oct 16, 2023

Describe the bug
'Addon Import' modal fails to complete action upon interaction with 'Import' primary button after pasting in code from WoWSims Importer In-Game Addon

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wowsims.github.io/wotlk/balance_druid/
  2. Click on 'Import' menu item in header
  3. Scroll down to 'Addon' sub menu link
  4. Paste in code from WoWSims Importer In-Game Addon
    sim bug.txt
  5. Click 'Import'
  6. Nothing happens in the UI, error message occurs in Console
    VM157:1 Uncaught (in promise) SyntaxError: Unexpected token 'h', "https://co"... is not valid JSON

Expected behavior

  1. Go to https://wowsims.github.io/wotlk/balance_druid/
  2. Click on 'Import' menu item in header
  3. Scroll down to 'Addon' sub menu link
  4. Paste in code from WoWSims Importer In-Game Addon
  5. Click 'Import'
  6. Native prompt to confirm 'Import complete'
  7. Close prompt and 'Import' modal
  8. Gear/Enchants etc is available on the main 'Gear' tab and is configurable

Sim Links and Screenshots
Error message, relating to replication steps:
aTJx8F3
Import code from addon: sim bug.txt
console log: wowsims.github.io-1697454085933.log

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 118

Smartphone (please complete the following information):
n/a

Additional context
I used this feature just last week on my other device - a MacOS device, running Safari. Unknown version number sorry. I can retrieve if needed but it is offsite.

@xonkz
Copy link
Author

xonkz commented Oct 16, 2023

Closing issue - user error
I accidentally added a breaker into the talent ID

WAS (Error)
{"talents":"0532013100300000000000000000-000000000000000000000000000000-230033 312031500531050313051","glyphs":{"major":[{"name":"Glyph of Swiftmend","spellID":54824},{"name":"Glyph of Wild Growth","spellID":62970},{"name":"Glyph of Rejuvenation","spellID":54754}],"minor":[{"name":"Glyph of Unburdened Rebirth","spellID":57857},{"name":"Glyph of the Wild","spellID":57855},{"name":"Glyph of Dash","spellID":59219}]},"class":"druid","bagItems":[],"race":"NightElf","name":"Xonk","gear":{"items":[{"enchant":3819,"gems":[41401,40133],"id":47959},{"id":47144,"gems":[40155]},{"enchant":3809,"gems":[42144],"id":48137},{"enchant":3859,"gems":[40113],"id":51584},{"enchant":3832,"gems":[40113,40133],"id":48166},{"enchant":2332,"gems":[40174],"id":47066},{"enchant":3604,"gems":[40155],"id":48163},{"id":47140,"gems":[40155,42144]},{"enchant":3719,"gems":[40113,40133,40133],"id":47062},{"enchant":3606,"gems":[40113,40152],"id":45135},{"id":47732,"gems":[]},{"id":50397,"gems":[]},{"id":46051,"gems":[]},{"id":48724,"gems":[]},{"enchant":3854,"gems":[40133,42144],"id":47524},null,{"id":47671,"gems":[]}]},"professions":[{"name":"Engineering","level":450},{"name":"Jewelcrafting","level":450}],"level":80,"spec":"feral","realm":"PyrewoodVillage"}

FIX
{"talents":"0532013100300000000000000000-000000000000000000000000000000-230033312031500531050313051","glyphs":{"major":[{"name":"Glyph of Swiftmend","spellID":54824},{"name":"Glyph of Wild Growth","spellID":62970},{"name":"Glyph of Rejuvenation","spellID":54754}],"minor":[{"name":"Glyph of Unburdened Rebirth","spellID":57857},{"name":"Glyph of the Wild","spellID":57855},{"name":"Glyph of Dash","spellID":59219}]},"class":"druid","bagItems":[],"race":"NightElf","name":"Xonk","gear":{"items":[{"enchant":3819,"gems":[41401,40133],"id":47959},{"id":47144,"gems":[40155]},{"enchant":3809,"gems":[42144],"id":48137},{"enchant":3859,"gems":[40113],"id":51584},{"enchant":3832,"gems":[40113,40133],"id":48166},{"enchant":2332,"gems":[40174],"id":47066},{"enchant":3604,"gems":[40155],"id":48163},{"id":47140,"gems":[40155,42144]},{"enchant":3719,"gems":[40113,40133,40133],"id":47062},{"enchant":3606,"gems":[40113,40152],"id":45135},{"id":47732,"gems":[]},{"id":50397,"gems":[]},{"id":46051,"gems":[]},{"id":48724,"gems":[]},{"enchant":3854,"gems":[40133,42144],"id":47524},null,{"id":47671,"gems":[]}]},"professions":[{"name":"Engineering","level":450},{"name":"Jewelcrafting","level":450}],"level":80,"spec":"feral","realm":"PyrewoodVillage"}

@xonkz xonkz closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant