Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APL Rotations don't report Time Spent OOM #3903

Closed
raethkcj opened this issue Oct 17, 2023 · 1 comment · Fixed by #3922 or #3947
Closed

APL Rotations don't report Time Spent OOM #3903

raethkcj opened this issue Oct 17, 2023 · 1 comment · Fixed by #3922 or #3947
Labels
bug Something isn't working

Comments

@raethkcj
Copy link
Contributor

raethkcj commented Oct 17, 2023

Describe the bug
With Legacy rotations, the sim always reported Time Spent OOM on the Damage tab, making it easy to know when you needed to make adjustments to your rotation to conserve mana. Using APL rotations, the Time Spent OOM always displays 0.0s spent OOM, which can lead to unexpected and misleading increases/decreases when players make certain gear or rotation changes.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wowsims.github.io/wotlk/elemental_shaman/#eJzjkuFgsmD0YJzAyPiA6Q3LCkbGDYxMBxgZLzAyvmBkdBLiYJRgVGAyYLRgdACqCmCMYBRikNrN1sTIFpCTWJlaxMEuwC71kJGLX2DpBGaJN7JKbEcPMW3cycTFKfCom1mJ+TaQyS/Q1cMs8QgoB5QAyfEIHOlmluiShUkvB2r9AZE+BhTgFfgPlJ4jpMQClGYAcpcB5afIKLFsBHH5BbYCDeaEGLURrH8JUL4Toh9iYDfQvk9AgWM7oW651wl1C6fAC5CzQKIsAms6mYHkXiDJI7AOqOWXLESGR2AH0AEvOCBaWARmdTEr8XIwGjAGsESwVjB2MDIuYvrKxHWAiWEwgYjbBwbaCaQCIQNSdVSxcTAKMBUwJplxKUlxAdnMEswKwJjhYPQEyzcEOARCGA4ODoxSAhyMyKoUGLsYg4xNjQ0MDAxNjYyNDI2NTQ2NjYyMDQyBDF0DA1MgNDA2NMACdLEJQsAjRgmOA0eYBC48ZZLYc4RJ4dclJo3f95gM/lxiesHI8oGRexYjwyEmhluMDLOYGJQmMnNC/JLpIAhhqDhIzpoJAiftLSEiF+wV08Dgmr3RQ6YqNvf8otz8bIVgCTYtGqc6jU4HahjTcPIIAXOC8ck77Jid5kgNd2ADkDAOe+wAteGHfRDe3GyREjS3of+eParoB3u379N3vNh72V5k4i+jFb+W289myjpr5PvKvuvtvA9/lr2yx27a8AWk5+YoknUAAPeMtIE
  2. Go to Results -> Damage tab, sim at least 1 iteration
  3. Observe the sim reports 65ish seconds spent OOM
  4. Go to Rotation, choose Default APL
  5. Go to Results -> Damage tab, sim at least 1 iteration
  6. Observe the sim reports 0 seconds spent OOM
  7. Go to Results -> Timeline tab
  8. Scroll through the timeline and observe many missed casts due to being OOM

Expected behavior
Results -> Damage -> Time spent OOM with APL rotation should show a similar 65ish seconds as Legacy rotations.

Desktop (please complete the following information):

  • OS: Windows 10 22H2
  • Browser: Firefox
  • Version: 119

Additional context
This was mentioned in Discord a few times but I wanted to file a formal issue so it doesn't get missed.

@lime-green lime-green added the bug Something isn't working label Oct 18, 2023
@raethkcj
Copy link
Contributor Author

Thanks for looking into this, unfortunately the repro steps still result in 0.0 seconds spent OOM with APL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants