db: rotation spells addition and cleanup #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jarveson
commented
Aug 11, 2023
jarveson
commented
- cleans up and adds in missing buffs/debuffs into the db
- initiates char sims and pulls spell book out, semi hacky but should get most of the rotation spells used to be added to db as well
- lowers the ~20 1kb or so requests each sim makes for missing spells in exchange for 10kb db increase
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
- semi hackily initiate a sim and rip out the 'spellbook' - increases db by about raw 10kb, which should be a net win as each sim used to make ~20 extra 1kb requests each load Signed-off-by: jarves <jarveson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.