Rogue Weapon Specializations #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related changes [rogue] "Close Quarters Combat" now visibly increases physical crit chance if a Dagger or Fist Weapon is equipped in the main hand (cp. issue wowsims#2744) [rogue] "Focused Attacks" energyPerSecond() estimate now honors the crit cap, and possible mh/oh differences
catszeid
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Looks good to me. Took me a second to understand the talent application, but that looks correct and should mostly match the behavior for the linked issue from wherefore.
- Maces will add regardless of MH or OH as intended.
- Daggers/Fist will show the additional crit in stats for MH regardless of if OH matches too, but I think that is fine. You handled the removal of the extra crit if it doesn't match the talent.
jimmyt857
approved these changes
Aug 18, 2023
|
Yup looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] removed redundant "target" from Spell.PhysicalCritChance() and related changes
[rogue] "Close Quarters Combat" now visibly increases physical crit chance if a Dagger or Fist Weapon is equipped in the main hand (fixes #2744)
[rogue] "Focused Attacks" energyPerSecond() estimate now honors the crit cap, and possible mh/oh differences
@where-fore Does this now behave as expected (with regard to #2744)?