Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enhancement p3 presets #3508

Merged
merged 2 commits into from
Aug 20, 2023
Merged

add enhancement p3 presets #3508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d8981
add enhancement p3 presets
kayla-glick Aug 20, 2023
19581b6
add faction conditions
kayla-glick Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions ui/enhancement_shaman/presets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {
CustomSpell,
ItemSwap,
ItemSpec,
Spec,
Faction,
} from '../core/proto/common.js';
import { SavedTalents } from '../core/proto/ui.js';

Expand All @@ -31,6 +33,7 @@ import {
} from '../core/proto/shaman.js';

import * as Tooltips from '../core/constants/tooltips.js';
import { Player } from 'ui/core/player.js';

// Preset options for this spec.
// Eventually we will import these values for the raid sim too, so its good to
Expand Down Expand Up @@ -223,3 +226,54 @@ export const P2_PRESET_WF = {
]
}`),
};

export const P3_PRESET_ALLIANCE = {
name: 'P3 Preset Alliance',
enableWhen: (player: Player<Spec.SpecElementalShaman>) => player.getFaction() == Faction.Alliance,
tooltip: Tooltips.BASIC_BIS_DISCLAIMER,
gear: EquipmentSpec.fromJsonString(`{ "items": [
{"id":48353,"enchant":3817,"gems":[41398,40128]},
{"id":47060,"gems":[40159]},
{"id":48351,"enchant":3808,"gems":[40128]},
{"id":47552,"enchant":3722,"gems":[40159]},
{"id":46965,"enchant":3832,"gems":[40159,49110,40128]},
{"id":47916,"enchant":3845,"gems":[40159,0]},
{"id":48354,"enchant":3604,"gems":[40128,0]},
{"id":47112,"enchant":3599,"gems":[40128,40159,40128]},
{"id":48352,"enchant":3823,"gems":[40128,40128]},
{"id":47099,"enchant":3606,"gems":[40128,40128]},
{"id":46046,"gems":[40128]},
{"id":47075,"gems":[40128]},
{"id":47188},
{"id":45609},
{"id":47206,"enchant":3789},
{"id":47156,"enchant":3789,"gems":[40128]},
{"id":47666}
]}`),
}


export const P3_PRESET_HORDE = {
name: 'P3 Preset Horde',
enableWhen: (player: Player<Spec.SpecElementalShaman>) => player.getFaction() == Faction.Horde,
tooltip: Tooltips.BASIC_BIS_DISCLAIMER,
gear: EquipmentSpec.fromJsonString(`{ "items": [
{"id":48358,"enchant":3817,"gems":[41398,40128]},
{"id":47433,"gems":[40159]},
{"id":48360,"enchant":3808,"gems":[40128]},
{"id":47551,"enchant":3722,"gems":[40159]},
{"id":47412,"enchant":3832,"gems":[40159,49110,40128]},
{"id":47989,"enchant":3845,"gems":[40159,0]},
{"id":48357,"enchant":3604,"gems":[40128,0]},
{"id":47460,"enchant":3599,"gems":[40128,40159,40128]},
{"id":48359,"enchant":3823,"gems":[40128,40128]},
{"id":47456,"enchant":3606,"gems":[40128,40128]},
{"id":46046,"gems":[40128]},
{"id":47443,"gems":[40128]},
{"id":47477},
{"id":45609},
{"id":47483,"enchant":3789},
{"id":47475,"enchant":3789,"gems":[40128]},
{"id":47666}
]}`),
}
2 changes: 2 additions & 0 deletions ui/enhancement_shaman/sim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ export class EnhancementShamanSimUI extends IndividualSimUI<Spec.SpecEnhancement
Presets.P1_PRESET,
Presets.P2_PRESET_FT,
Presets.P2_PRESET_WF,
Presets.P3_PRESET_ALLIANCE,
Presets.P3_PRESET_HORDE,
],
},
});
Expand Down
Loading