vigo/autoAttacks #3601
Merged
vigo/autoAttacks #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ReplaceMHSwing must not return nil, but the default swing instead - removed OH syncing support, it's handled via ReplaceMHSwing now (shaman only) - removed PreviousSwingAt tracking, it's handled via OnAutoAttack() now (shaman only) - curMeleeSpeed (formerly curSwingSpeed) is now used to cache swing durations (curXXSwingDuration), so TrySwingXX() can re-use 'em - additionally caching curRangedSpeed and curRangedSwingDuration now - replaced IsEnabled() by querying AutoSwingMelee or AutoSwingRanged - split many functions into melee or ranged parts, and resetAutoSwing() into rescheduleMelee() and rescheduleRanged() [dk, hunter, druid, warrior] updated ReplaceMHSwing use cases accordingly [shaman] moved OH syncing support and PreviousSwingAt tracking here; syncing can no longer /lower/ the offhand swing time [hunter] updated dynamic ranged attack speed changes to use MultiplyRangedSpeed(), and have Frenzy properly use MultiplyMeleeSpeed() [web] updated testing equip from TBC to WotLK, so it no longer crashes unnoticed because of missing items
# Conflicts: # sim/shaman/enhancement/TestEnhancement.results
# Conflicts: # sim/shaman/enhancement/TestEnhancement.results
# Conflicts: # sim/shaman/enhancement/TestEnhancement.results
Horatio27
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] AutoAttack changes:
[dk, hunter, druid, warrior] updated ReplaceMHSwing use cases accordingly
[shaman] moved OH syncing support and PreviousSwingAt tracking here; syncing can no longer /lower/ the offhand swing time
[hunter] updated dynamic ranged attack speed changes to use MultiplyRangedSpeed(), and have Frenzy properly use MultiplyMeleeSpeed()
[web] updated testing equip from TBC to WotLK, so it no longer crashes unnoticed because of missing items