vigo/item-sets #3630
Merged
vigo/item-sets #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… speeding up tests [common/tbc] "fix" Stormshroud Armor using the same random name for both 2pc and 3pc [tools/database] fixed the bug that caused "Revert recent changes to DB writing code that broke DB generation."
# Conflicts: # sim/druid/feral/TestFeralDoubleArmorPenTrinketsNoDesync.results # sim/druid/feral/TestFeralDoubleArmorPenTrinketsWithDesync.results
[tools] additionally updated ReadWeb() to reuse the (default) http.Client, as recommended, and close the response body after use
# Conflicts: # sim/druid/feral/TestFeral.results # sim/druid/feral/TestFeralDoubleArmorPenTrinketsNoDesync.results # sim/druid/feral/TestFeralDoubleArmorPenTrinketsWithDesync.results # sim/rogue/TestAssassination.results # sim/rogue/TestCombat.results
# Conflicts: # sim/common/wotlk/nibelung.go
# Conflicts: # sim/common/wotlk/nibelung.go
jarveson
added a commit
to jarveson/wotlk
that referenced
this pull request
Sep 11, 2023
- reverts change from wowsims#3630 Signed-off-by: jarves <jarveson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] remove ItemSet.Items and itemSetLookup, as they're exclusively speeding up tests
[common/tbc] "fix" Stormshroud Armor using the same random name for both 2pc and 3pc
[tools/database] fixed the bug that caused "Revert recent changes to DB writing code that broke DB generation."