Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suggest gemming shared & add for hunter #3787

Closed
wants to merge 24 commits into from

Conversation

1337LutZ
Copy link
Contributor

Tried to make the suggest option more generic to be more easily implemented by other classes.
(I know the feature in general was/is pretty tailored towards ArP users that rely on quite "flat" caps)

  • Moved all auto gem code to shared folder
  • Incorporated existing spec (Feral/Warrior) specific logic
  • Added Hunter (need a check on this but it seems to work pretty well vs existing BIS sets)
  • Tweaked Warrior gemming to allow for gemming ArP in yellow sockets

@hululula
Copy link

hululula commented Oct 7, 2023

Worked with 1337LutZ to verify the gemming configurations and it looks good to me now. (Monsterik in discord)

@1337LutZ 1337LutZ marked this pull request as ready for review November 6, 2023 15:29
@NerdEgghead NerdEgghead closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants