Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jake/apl tests #3789

Merged
merged 21 commits into from
Oct 6, 2023
Merged

Jake/apl tests #3789

merged 21 commits into from
Oct 6, 2023

Conversation

jarveson
Copy link
Contributor

@jarveson jarveson commented Sep 30, 2023

  • rip apl presets into 'json' files, so that they can be pulled into test functions and tested

@jarveson jarveson marked this pull request as draft September 30, 2023 23:32
@lologarithm
Copy link
Contributor

idea to go with a PR I am cooking up, name all apl files

XXX.apl.json -- this will let you edit those files with auto-completion once I get this readme in on how to make autocomplete work!

Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
Signed-off-by: jarves <jarveson@gmail.com>
@jarveson
Copy link
Contributor Author

jarveson commented Oct 6, 2023

@lologarithm renamed them as suggested

@jarveson jarveson merged commit 0a77a49 into wowsims:master Oct 6, 2023
1 check passed
@jarveson jarveson deleted the jake/apl-tests branch October 6, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants