Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Possible docker permissions issue #3806

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

1337LutZ
Copy link
Contributor

@1337LutZ 1337LutZ commented Oct 3, 2023

Running Ubuntu 20.04 on WSL2 Windows 11.

I encountered this issue after getting the latest changes which included the update to go:1.21:

$(echo $WOTLK_CMD) make release
make: Circular ui/core/index.ts <- ui/core/index.ts dependency dropped.
Starting server compile now...
go: downloading github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8
go: downloading github.com/google/uuid v1.3.1
go: downloading golang.org/x/exp v0.0.0-20221028150844-83b7d23a625f
Build Completed Successfully
cp ./assets/favicon_io/icon-windows_amd64.syso ./sim/web/icon-windows_amd64.syso
cd ./sim/web/ && GOOS=windows GOARCH=amd64 GOAMD64=v2 go build -o wowsimwotlk-windows.exe -ldflags="-X 'main.Version=' -s -w"
go: downloading golang.org/x/sys v0.1.0
error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.
make: *** [makefile:180: wowsimwotlk-windows.exe] Error 1

It seems in some user scenarios the files that are copied in the Docker container aren't owned by the same user and when go is being executed it fails due to this.

Description: golang/go#51253 (comment)
Fix: golang/go#51253 (comment)

@lime-green lime-green merged commit a3184fc into wowsims:master Oct 3, 2023
2 checks passed
@1337LutZ 1337LutZ deleted the fix/docker-permissions-issue branch October 3, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants