Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple-perf-measures #3837

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

vigo2
Copy link
Contributor

@vigo2 vigo2 commented Oct 7, 2023

[core] don't needlessly reset auraTracker.minExpires fully after Refresh() or Deactivate() anymore

[character] advance() assumes that pets don't have pets anymore

I'm planning to make some more changes building on the latter assumption - does that sound viable?

…esh() or Deactivate() anymore

[character] advance() assumes that pets don't have pets anymore
@vigo2 vigo2 requested a review from jimmyt857 October 7, 2023 18:01
Copy link
Contributor

@jimmyt857 jimmyt857 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes AFAIK it's a valid assumption that pets won't have pets.

@vigo2 vigo2 merged commit 1b855ff into wowsims:master Oct 9, 2023
2 checks passed
@vigo2 vigo2 deleted the vigo/simple-perf-measures branch October 9, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants