-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft - Proposal for code linting #3839
Draft - Proposal for code linting #3839
Conversation
Hey @1337LutZ 👋 I know this has been open for a while but I'd love to get better linting and prettier in. Would you have any interest in continuing this PR? It's still in draft so I'm not sure if it's ready or not |
Hey @kayla-glick, Yea sure can do! |
@kayla-glick I updated it with the latest master builds. Feel free to play around with it. I haven't changed any imports / warnings yet since it'll be over 200+ files. |
Thanks for that! I'll pull down this branch and take a look at what the formatting does to make sure the settings are set up how we'd want them too |
Sweet, nice to hear! |
Best to check out this branch and run the commands for yourself.
Didn't commit all the file changes that would happen because of this (over 300).
Have a branch where I ran this command but haven't fixed all the code smells/warnings yet (there's a lot). If there's interest I can go through all the files and fixed them in one fell swoop.
.vscode
folder from.gitignore
so project settings are picked up when the project is clonedcodeActionsOnSave
command for relevant files.vscode/extensions.json
to notify developers for suggested extensions when working on this projectcommands
npm run format
will auto fix and format css (scss) and js (ts) filesnpm run lint
will lint all js and css filesnpm run lint:{js/css}
will lint all js or css filesnpm run lint:{js/css}:fix
will fix all js or css files based on linting rulesnpm run prettier
will check all js, json and css files for formattingnpm run prettier:fix
will fix formatting for all js and css files