fix weird tricks + MCD interaction #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lime-green
commented
Oct 8, 2023
| mcdm.minReady = mcdm.majorCooldowns[0].ReadyAt() | ||
| } | ||
|
|
||
| // This function should be called if the CD for a major cooldown changes outside | ||
| // of the TryActivate() call. | ||
| func (mcdm *majorCooldownManager) UpdateMajorCooldowns() { | ||
| if mcdm.tryUsing { |
There was a problem hiding this comment.
afaik it shouldn't be a big deal if this happens, and occurs for tricks because tricks needs to update MCD on its cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was causing rogue cooldowns not to be cast if tricks was cast pre-pull