vigo/hardcast-out-of-advance #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ardcastAction and gcdAction), so it's not needlessly checked for other actions
# Conflicts: # sim/priest/shadow/TestShadow.results # sim/shaman/enhancement/TestEnhancement.results
jimmyt857
approved these changes
Oct 12, 2023
# Conflicts: # sim/hunter/TestMM.results # sim/mage/TestArcane.results # sim/mage/TestFire.results # sim/mage/TestFrost.results # sim/mage/TestFrostFire.results # sim/shaman/elemental/TestElemental.results # sim/shaman/enhancement/TestEnhancement.results # sim/shaman/restoration/TestRestoration.results # sim/warlock/TestAffliction.results # sim/warlock/TestDemonology.results # sim/warrior/dps/TestArms.results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] move Hardcast handling out of advance() into PendingActions (hardcastAction and gcdAction), so it's not needlessly checked for other actions
This is a speedup for all classes, depending on how many PAs are non-gcdAction and non-hardcastActions. For DKs w/ Night of the Dead, it's a ~5% speedup, quite large for such a simple measure.
Test changes look fine, all "Averages" are still within expected ranges.