Vigo/faster advance #3877
Merged
Vigo/faster advance #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimal test changes for different iteration order
- updated tests - slight cleanups
jimmyt857
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] Simulation.advance() now iterates over enabled units' auraTrackers, and caches their combined "minExpires" to skip iterating when there's nothing to do
[core] removed some needless method shadowing for Target, Character, and Pet
[core] added Stats.Invert() as a shortcut for Stats.Multiply(-1), and simplified most others
Test changes only happen because the order of
advance()calls isn't the same as before. DPS changes are typically in the noise.