Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shadowfiend scaling #3904

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

lime-green
Copy link
Contributor

@lime-green lime-green commented Oct 18, 2023

https://docs.google.com/spreadsheets/d/1ctQRsrlzE_AVyNA9nbrTOUbLwe28zYTk_T461_DJ3YM/edit#gid=0

Bunch of shadowfiend scaling fixes after investigation:

  • Shadowfiend doesn't miss (no misses, dodges, parries)
  • Shadowfiend base damage was too high
  • Shadowfiend SP scaling was too high
  • Shadowfiend strength scaling was incorrect
  • Crit % in logs is much higher, around 9-12% but I didn't test this explicitly, so it's around 11% now

Also fix shadow priest presets

Shadowfiend stats were viewed in-game with the help of:
/run if not oldHasPetUI then oldHasPetUI = HasPetUI; HasPetUI = function() return true, false; end end PetTab_Update() ToggleCharacter("PetPaperDollFrame")

image

@lime-green lime-green merged commit 41e1712 into wowsims:master Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant