From eb266671719f17042fd1cdbca992d6ddb42b41fe Mon Sep 17 00:00:00 2001 From: Grzegorz Prajsner Date: Sun, 22 Oct 2023 23:23:42 +0200 Subject: [PATCH 1/2] sim/warrior: fix Shield Wall/Shield Wall glyph Fix damage reduction on Shield Wall. Shield Wall with glyph should reduce damage by 40% (0.6 damage taken coefficient) and without glyph by 60% (0.4 damage coeff). Before the patch it was other way around and was incorrect. Signed-off-by: Grzegorz Prajsner --- sim/warrior/shield_wall.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/warrior/shield_wall.go b/sim/warrior/shield_wall.go index c55505729e..e507f03265 100644 --- a/sim/warrior/shield_wall.go +++ b/sim/warrior/shield_wall.go @@ -15,7 +15,7 @@ func (warrior *Warrior) RegisterShieldWallCD() { duration := time.Second*12 + core.TernaryDuration(warrior.HasSetBonus(ItemSetDreadnaughtPlate, 4), time.Second*3, 0) hasGlyph := warrior.HasMajorGlyph(proto.WarriorMajorGlyph_GlyphOfShieldWall) //This is the inverse of the tooltip since it is a damage TAKEN coefficient - damageTaken := core.TernaryFloat64(hasGlyph, 0.4, 0.6) + damageTaken := core.TernaryFloat64(hasGlyph, 0.6, 0.4) actionID := core.ActionID{SpellID: 871} swAura := warrior.RegisterAura(core.Aura{ From 7955546b156ab7c3c641e1a874364322c8907baf Mon Sep 17 00:00:00 2001 From: Grzegorz Prajsner Date: Sun, 22 Oct 2023 23:27:53 +0200 Subject: [PATCH 2/2] tests: fix expected weights for warriors after SW fix Signed-off-by: Grzegorz Prajsner --- .../protection/TestProtectionWarrior.results | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sim/warrior/protection/TestProtectionWarrior.results b/sim/warrior/protection/TestProtectionWarrior.results index c279f26b00..9cabbb145e 100644 --- a/sim/warrior/protection/TestProtectionWarrior.results +++ b/sim/warrior/protection/TestProtectionWarrior.results @@ -46,7 +46,7 @@ character_stats_results: { stat_weights_results: { key: "TestProtectionWarrior-StatWeights-Default" value: { - weights: 1.01803 + weights: 0.84402 weights: 0 weights: 0 weights: 0 @@ -57,7 +57,7 @@ stat_weights_results: { weights: 0 weights: 0 weights: 0 - weights: 0.19691 + weights: 0.26128 weights: 0 weights: 0 weights: 0 @@ -66,12 +66,12 @@ stat_weights_results: { weights: 0 weights: 0 weights: 0 - weights: 0.02012 + weights: 0.01763 weights: 0 weights: 0 weights: 0 - weights: 0.42911 - weights: 0.07235 + weights: 0.4296 + weights: 0.02365 weights: 0 weights: 0 weights: 0 @@ -921,9 +921,9 @@ dps_results: { dps_results: { key: "TestProtectionWarrior-Average-Default" value: { - dps: 2772.35319 - tps: 6734.95331 - dtps: 127.69906 + dps: 2771.43209 + tps: 6732.50018 + dtps: 127.46896 } } dps_results: {