Vigo/weapon preps #3957
Merged
Vigo/weapon preps #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] switching weapons (SetMH/OH/Ranged) now also takes care of updating the related spell's crit multiplier, fixing it for druid shapeshifting with Predatory Instincts [common,paladin,rogue,warrior] simplify extra attack spells, fixes an oversight for paladin's reckoning
# Conflicts: # sim/deathknight/dps/TestBlood.results
jimmyt857
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] only call DoNextRotation pre-MH-swing if a ReplaceMHSwing is registered
This changes test results for all melee classes not using ReplaceMHSwing very slightly. It's almost a 10% perf improvement running APL rotations for those classes.
[core] make most of AutoAttacks' fields private
[core] switching weapons (SetMH/OH/Ranged) now also takes care of updating the related spell's crit multiplier, fixing it for druid shapeshifting with Predatory Instincts
[common,paladin,rogue,warrior] simplify extra attack spells, fixes an oversight for paladin's reckoning
These are preparations for an upcoming auto attack PR, but also fix some (very) minor bugs.