Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vigo/weapon preps #3957

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Vigo/weapon preps #3957

merged 4 commits into from
Oct 28, 2023

Commits on Oct 26, 2023

  1. [core] only call DoNextRotation pre-MH-swing if a ReplaceMHSwing is r… 

    …egistered
    @vigo2
    vigo2 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    7d0e961 View commit details
    Browse the repository at this point in the history

  2. [core] make most of AutoAttacks' fields private 

    [core] switching weapons (SetMH/OH/Ranged) now also takes care of updating the related spell's crit multiplier, fixing it for druid shapeshifting with Predatory Instincts
[common,paladin,rogue,warrior] simplify extra attack spells, fixes an oversight for paladin's reckoning
    @vigo2
    vigo2 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3ae07b3 View commit details
    Browse the repository at this point in the history

  3. [core] rename DualWielding() "back" to IsDualWielding()

    @vigo2
    vigo2 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    a6c8c67 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge branch 'master' into vigo/weapon-preps 

    # Conflicts:
#	sim/deathknight/dps/TestBlood.results
    @vigo2
    vigo2 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    13ae60c View commit details
    Browse the repository at this point in the history