Update Elemental T10 4pc #3981
Merged
Update Elemental T10 4pc #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on logs, Flame Shock with Elemental Shaman's T10 4-set bonus behaves differently than other refreshed/rolled over DoTs.
Logs: https://classic.warcraftlogs.com/reports/a:9KMHBQnN8tAZfwJr#fight=37&type=summary&source=36&view=events
Spreadsheet showing the relevant timeline of events: https://docs.google.com/spreadsheets/d/1ToSXfky85q8fzkPTFGiT9xnldzipEc5vb4p7h7IsZSU/edit#gid=2029445151
Our conclusion is that Flame Shock dynamically updates its haste when Lava Burst finishes casting (not when it hits). Check the Lava Burst casts at 71 seconds (after gaining Hyperspeed Acceleration) and at 220 seconds (after losing Heroism), and note that Flame Shock updates its tick interval for the current tick immediately, before the Lava Burst hits the target.
I tried making use of the existing Rollover function, but ultimately concluded the behavior was too different, thus
RescheduleNextTick. I also took queues from feral/rogue sims for the NumberOfTicks overwrite.