Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OOC: PPM should be constant with haste #3983

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

lime-green
Copy link
Contributor

@lime-green lime-green commented Oct 31, 2023

https://classic.warcraftlogs.com/reports/J7N3nyDMBWRjYZCK#boss=-3&difficulty=0&source=1&type=casts

User told me they had 709 haste:

3000 / (1+709/3279) = 2466


You had 50.7% Nature's Grace uptime on your log:
3000 / ((1+(709+340*0.1739)/3279)*(1+0.2*0.507)) = 2206


Calculating expected OOC proc rate:
(2.206 / 60) * 3.5 * 0.666 = 0.086


Log Proc Rate:
151 / 2,015 = 0.0749

checks out

95% CI is 1.1%, a bit off but nature's grace calc is napkin-y and would have higher uptime bc/ it would apply for the full cast even if it falls off during the cast. If PPM wasn't constant with haste we would see:

(3 / 60) * 3.5 * 0.666 = 0.11655

clearly isn't right

@lime-green lime-green merged commit 2382b6f into wowsims:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant