Vigo/auto attacks #3985
Merged
Vigo/auto attacks #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[warrior] ranged attacks (namely Thunder Clap) now properly trigger MH Deep Wounds
[core] slightly speedup advance() by using an inlineable tryAdvance() stub
jimmyt857
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] introduce WeaponAttack, a per weapon (MH, OH, Ranged) AutoAttack
[warrior] ranged attacks (namely Thunder Clap) now properly trigger MH Deep Wounds
No test changes but for Arms-Warrior.
[core] handle WeaponAttacks via a "task"-like system
[core] slightly speedup advance() by using an inlineable tryAdvance() stub
Affected "Average" tests are mostly unchanged. For e.g. DKs and Enhancement Shamans, this is almost a ~10% perf gain (non-APL).