Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blood DK Legacy Rotation Opener Usage of Blood Tap with new 4pc cooldown consideration #4043

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix Blood DK Legacy Rotation Opener Usage of Blood Tap with new 4pc cooldown consideration #4043

merged 2 commits into from
Nov 14, 2023

Commits on Nov 13, 2023

  1. Configure Blood DK Normal and Threat Openers to conditionally skip us… 

    …ing Blood Tap and the subsequent Icy Touch enabled by it.

If the DK has the T10 4pc bonus enabled and does not schedule the first Blood Tap usage outside the time the opener uses Blood Tap + the Blood Tap Cooldown, the noted spells will not be used in either opener scenario.

This change comes with a caveat of potentially delaying scheduled Blood Tap casts if the opener Blood Tap is delayed due to ability misses.
    cyzin committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    5cb836f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wowsims:master' into master

    @Cyzin1
    Cyzin1 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    31473e1 View commit details
    Browse the repository at this point in the history