Gem summary UI #4061
Merged
Gem summary UI #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: new file: ui/core/components/gem_summary_action.ts modified: ui/core/individual_sim_ui.ts
Changes to be committed: modified: ui/core/components/gem_summary_action.ts
Changes to be committed: modified: ui/core/components/gear_picker.tsx deleted: ui/core/components/gem_summary_action.ts modified: ui/core/individual_sim_ui.ts
kayla-glick
commented
Nov 22, 2023
| @@ -125,7 +125,7 @@ export class ItemRenderer extends Component { | |||
| readonly socketsContainerElem: HTMLElement; | |||
|
|
|||
| constructor(parent: HTMLElement, player: Player<any>) { | |||
| super(parent, 'item-picker-root'); | |||
| super(parent, 'item-renderer-root'); | |||
There was a problem hiding this comment.
The nested item-picker-root class was causing rendering issues particularly on mobile
NerdEgghead
reviewed
Nov 22, 2023
Comment on lines
25
to
30
| this.container = new ContentBlock(this.rootElem, 'gem-summary-container', { | ||
| header: {title: 'Gem Summary'} | ||
| }); | ||
|
|
||
| player.gearChangeEmitter.on(() => this.updateTable()); | ||
| } |
There was a problem hiding this comment.
Minor nit, but looks like indentation got messed up here maybe?
There was a problem hiding this comment.
Ah looks like my editor made these new lines use spaces instead of tabs. Nice catch! It looked fine for me because I use 2-space tab sizing but I'll bet it looks funky if you use anything else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struggled to push the latest updates to the fork's branch so re-opened the PR
Original PR #4050
Adds a summary of gems in the gear tab as requested by the community. Also makes some visual improves to the mobile layout of the gear tab.