Fix rare panic when swapping items #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
added a commit
that referenced
this pull request
Jan 29, 2024
kayla-glick
added a commit
that referenced
this pull request
Jan 29, 2024
* update protos for APL only * update most sim/core for APL only * update most sim/druid for APL only * remove custom_rotation.go * update hunter APL only * doNothing * update mage APL only * update paladin APL only * update priest APL only * update rogue APL only * update shaman APL only * update raid_bench_test.go * update warlock APL only * update enhancement.go * update warrior APL only * update main_test.go * update cast.go * add back TryUseCooldowns * fix some more sim errors * fix druid proto * fix hunter proto * all files gone through * api.proto comment * fix a few issues * fix from #4177 Fix rare panic when swapping items * apply #4199 Fix OOM calcs and more cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4146