Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if I'm making a mess, first time contributing, looking for feedback.
I thought about where to put the talent sims. My use case would be for example simming two set bonuses against eachother, but the set bonus requires a talent swap to maximise the dps.
So for now I've put it in the loop where we add the valid sims. There's still some issues, mainly in the GUI and we sim unnecessary talent loadouts right now. We shouldn't have to sim the currently loaded talent spec even if you pick it, because the bulksim does that automatically.
I think it's also important to note that this obviously multiplies the amount of sims that are needed for a result and so it only does the sims when activated.
It's not very nicely visualised in the UI either, and you probably want to equip the talent loadout as well on the button press.