Remove legacy rotation code from sod-fork #4206
Conversation
| @@ -43,7 +43,6 @@ func (cat *FeralDruid) OnGCDReady(sim *core.Simulation) { | |||
| // Replace gcd event with our own if we casted a spell | |||
| if !cat.GCD.IsReady(sim) { | |||
| nextGcd := cat.NextGCDAt() | |||
| cat.DoNothing() | |||
There was a problem hiding this comment.
Can this file be removed? It contains powershift logic
| @@ -393,20 +391,6 @@ export abstract class IndividualSimUI<SpecType extends Spec> extends SimUI { | |||
| //this.simHeader.addExportLink("CLI", _parent => new Exporters.IndividualCLIExporter(this.rootElem, this), true); | |||
| } | |||
|
|
|||
| applyDefaultRotation(eventID: EventID) { | |||
There was a problem hiding this comment.
This was an intentional add on my part to allow individual sims to specify the simple interface as what users see by default if desired. Should still work with the new code as long as the individual sim config supports optional fields within the defaults section for "rotationType?" and "simpleRotation?". I'm happy to re-commit it separately though if that's easier.
There was a problem hiding this comment.
The feral sim still shows the simple rotation and changing options does affect results, too.
There was a problem hiding this comment.
And with full buffs I get ~306 dps
There was a problem hiding this comment.
Yeah that commit wouldn't change results at all, just which interface is shown when loading defaults.
kayla-glick
changed the title
Working through #4116 and follow-up PRs to remove the old rotation code