Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header/metadata fix #10

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Header/metadata fix #10

merged 4 commits into from
Mar 16, 2024

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented Mar 16, 2024

this PR fix the issue around the missing data, but still some enhancements could be done

  • some package json data like "bug" can be both string or object but currently only the string version is captured
  • the email author is optional for the pot file header but is missing in the WordPress plugin or header
  • also composer.json can provide some info but currently isn't parsed at all

close #9

@johnhooks johnhooks mentioned this pull request Mar 16, 2024
@erikyo erikyo merged commit 9844ee5 into master Mar 16, 2024
6 checks passed
@johnhooks
Copy link
Contributor

@erikyo I'm getting some odd output, its labeling as comming from the style.css but I don't have one in my project.

#: style.css
#. Name of the vinyl
msgid "@wp-blocks/vinyl"
msgstr ""

#: style.css
#. Author of the vinyl
msgid "undefined"
msgstr ""

#: style.css
#. Description of the vinyl
msgid "An audio player WordPress block."
msgstr ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Header fix
2 participants