Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error with WooCommerce PayPal Payments #6064

Closed
4 tasks
rvola opened this issue Jul 25, 2023 · 7 comments
Closed
4 tasks

Fatal Error with WooCommerce PayPal Payments #6064

rvola opened this issue Jul 25, 2023 · 7 comments
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. priority: medium Issues which are important, but no one will go out of business. severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@rvola
Copy link

rvola commented Jul 25, 2023

Describe the bug
Since WP-Rocket 3.14. I get the following Fatal error:

Fatal error: Declaration of WooCommerce\WooCommerce\Logging\Logger\WooCommerceLogger::log($level, $message, array $context = []) must be compatible with Psr\Log\LoggerTrait::log($level, Stringable|string $message, array $context = []): void in /wp-content/plugins/woocommerce-paypal-payments/modules/woocommerce-logging/src/Logger/WooCommerceLogger.php online 58

To Reproduce
Activate the 3 plugins in the following order:

  1. WooCommerce 7.9.0 and earlier
  2. WP-Rocket 3.14.2.1
  3. WooCommerce PayPal Payments 2.2.0
  4. BOOM 💣

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Jul 25, 2023

Can reproduce the error with the following steps:

  1. WooCommerce 7.9.0
  2. WooCommerce PayPal Payments 2.2.0
  3. Install and activate WPR 3.14.2.1 using composer install
    [25-Jul-2023 08:50:05 UTC] PHP Fatal error: Declaration of WooCommerce\WooCommerce\Logging\Logger\WooCommerceLogger::log($level, $message, array $context = []) must be compatible with Psr\Log\LoggerTrait::log($level, Stringable|string $message, array $context = []): void in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/woocommerce-paypal-payments/modules/woocommerce-logging/src/Logger/WooCommerceLogger.php on line 58
    Notes:
  • PHP used is 8.2.8
  • The same is happening using WPR 3.12.6 + composer install
  • WPR debug is disabled
  • Using the zip file of 3.14.2.1 is working fine without any fatal error

@piotrbak piotrbak added type: bug Indicates an unexpected problem or unintended behavior priority: medium Issues which are important, but no one will go out of business. needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. severity: major Feature is not working as expected and no work around available 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting labels Jul 25, 2023
@remyperona
Copy link
Contributor

I believe this will be fixed in WP Rocket 3.15 via the following: #5366

@piotrbak

@piotrbak
Copy link
Contributor

@wp-media/qa Could you accomodate some time to test it against 5366 PR? (it's not a priority)

@CrochetFeve0251
Copy link
Contributor

The grooming looks fine to me

@vmanthos
Copy link
Contributor

vmanthos commented Aug 2, 2023

@piotrbak I checked this with https://github.com/wp-media/wp-rocket/tree/branch-3.15 where #5949 is merged and the fatal error isn't there.

@piotrbak
Copy link
Contributor

piotrbak commented Aug 2, 2023

@vmanthos Thank you! 🙏

@piotrbak piotrbak added this to the 3.15 milestone Aug 2, 2023
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 1, 2023

#6064 (comment) Fixed on 3.15 using PHP 8.2.9 without WPR debug. (If WPR debug is enabled, fatal will be there even without 3rd parties, related to #5918)

@piotrbak piotrbak closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. priority: medium Issues which are important, but no one will go out of business. severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

6 participants