dev: add filters to resolve_content_blocks()
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b64583f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
force-pushed
the
dev/resolve-content-blocks-filters
branch
from
1032004
to
b64583f
Compare
jasonbahl
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds the
wpgraphql_content_blocks_pre_resolve_blocksandwpgraphql_content_blocks_resolve_blocksfilters toContentBlocksResolver::resolve_content_blocks().Why
Beyond the general DX arguments, this allows local workarounds for the existing bugs without waiting for upstream patches by an understaffed team.
How
wpgraphql_content_blocks_pre_resolve_blocksreturns anything butnull, the results will be used instead. This is good for swapping out the entire resolver's results without resulting to a messy resolver overloading or forking.wpgraphql_content_blocks_resolve_blocksis used to filter the blocks after the::resolve_content_blocks()method processes them. This is good for hydrating missing values that the plugin doesnt handle currently/WP 6.5+ regressions.