dev: refactor ContentBlocksResolver and deprecate TraverseHelpers
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31944d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
force-pushed
the
dev/refactor-ContentBlocksResolver
branch
from
ccc2ac0
to
f0860a6
Compare
jasonbahl
reviewed
Sep 16, 2024
justlevine
force-pushed
the
dev/refactor-ContentBlocksResolver
branch
from
f0860a6
to
31944d8
Compare
theodesp
approved these changes
Sep 17, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR refactors
ContentBlocksResolverfor code complexity/maintainability (SOLID) and to better resembles WordPress's internal block parsing/rendering.More specifically,
::resolve_content_blocks()no longer retains any top-level logic, and instead blocks are parsed recursively (::parse_blocks() ->::handle_do_blocks()->::handle_do_block()` )As a result,
TraverseHelpershas been deprecated entirely.Why
This lays the groundwork for fixing missing values due to incorrect hydration, moving field resolution from resolvers to a model, fixing layout css classes, and a few performance improvement strategies I'm investigating.
Note
There is no pressing need to merge this until either more tests are backfilled or future PRs that actually address code issues are pushed for review.Followed up by #284