tests: fix setUp()/tearDown() methods
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d5e2c6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jasonbahl
approved these changes
Sep 19, 2024
|
@justlevine looks like one of the workflows is failing: https://github.com/wpengine/wp-graphql-content-blocks/actions/runs/10945698414 |
@jasonbahl That's either temporary issue or someone just committed an accidental breaking change to the nightlies. FWIW it passed for us: rtCamp#21 |
|
Ok cool. I can look at it later |
theodesp
approved these changes
Sep 23, 2024
|
Ta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the
::setUp()and::tearDown()methods in our PHPUnit test classes. More specificallyparent::tearDown()::tearDown()that were created in::setUp()$wpdbcalls.As a result,
markTestSkipped()has been removed fromCoreTableTestandCoreVideoTestsince they're no longer necessary.Additionally, the class namespace was added to
UpdateCallbacksTest.phpsince the autoload error was bothering me.Why
CoreImageTestis for some reason what's causingCoreTableTestetc to skip theirattributesregistration, and clearing the WPGraphQL schema allows it to work again.Made sense to apply it for equal measure, since the underlying issue is lifecycle issue between the plugin/PHPUnit (and not an issue in PHPUnit itself) and we don't want it rearing its head again forcing someone to disable a previously-working test.
Additional fixes are low-hanging fruit that don't deserve their own PR or the headache of working around merge conflicts during this sprint.