tests: Add tests for CoreHeading block
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cover the attributes that are null
…hql-content-blocks into core-heading-test
🦋 Changeset detectedLatest commit: 9bc6fe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
cc: @justlevine |
jasonbahl
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR backfills tests for the
CoreHeadingblock and its attributes.Tested attributes:
Untested fields:
CoreHeadingAttributes.metadata- @todoCoreHeadingAttributes.placeholder- Not explicitly tested, always returns null in current testsExposed issues:
CoreHeading.cssClassNames: returnsnulleven when the block has CSS classes. This is commented out in the test file.CoreHeadingAttributes.levelreturns aFloatinstead of anInteger. This is noted in a comment in the test file.These issues are noted in comments within the test file and should be addressed in future updates.