Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests : Add tests for CoreList block. #298

Merged
merged 15 commits into from
Oct 3, 2024
Merged

Conversation

Ta5r
Copy link
Contributor

@Ta5r Ta5r commented Sep 24, 2024

What:

This PR backfills tests for the Core List and Core List Item block and their attributes.

Tested attributes:

CoreListAttributes

  • anchor
  • backgroundColor
  • className
  • cssClassName
  • fontFamily
  • fontSize
  • gradient
  • lock
  • ordered
  • placeholder
  • reversed
  • start
  • style
  • textColor
  • type
  • values

CoreListItemAttributes

  • className
  • content
  • fontFamily
  • fontSize
  • lock
  • style

Untested fields:

  • CoreListAttributes.metadata - @todo

Exposed issues:

  • CoreListAttributes.cssClassNames - This is not working in the tests.

These issues are noted in comments within the test file and should be addressed in future updates.

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 3972c4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wp-graphql-content-blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ta5r
Copy link
Contributor Author

Ta5r commented Sep 24, 2024

c.c. @justlevine 🚀

@Ta5r Ta5r marked this pull request as ready for review September 24, 2024 13:13
@Ta5r Ta5r requested a review from a team as a code owner September 24, 2024 13:13
@jasonbahl jasonbahl merged commit 2064f09 into wpengine:main Oct 3, 2024
10 of 11 checks passed
@justlevine justlevine deleted the core-list-test branch October 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants