-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UR-1083 Fix - Make login shortcode compatible with all editors #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekhnath005
requested review from
deepench,
salimshrestha98,
dipuchaudhary,
iamprazol and
MILAN88888
July 19, 2023 10:21
MILAN88888
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
salimshrestha98
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! 👍
dipuchaudhary
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
lekhnath005
pushed a commit
that referenced
this pull request
Aug 8, 2023
Squashed with the following commits : commit 2c0acb7 (HEAD -> develop, origin/develop) Author: dipuchaudhary <dipuchaudhary8@gmail.com> Date: Mon Aug 7 21:13:52 2023 +0545 Tweak - Header format of mail commit 8d210aa Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Mon Aug 7 17:15:23 2023 +0545 UR-830 Feature - Email preview (#551) * Tweak - Remove redundant code * Add - Preview feature for emails * Implemented default template in emails and preview * Enhance - Default template added to wrap emails while sending and previewing * Sync code to Pro * default email template design fixes * Tweak - Remove wp header and footer from preview * default email template font family set * not scrolling when multiple content fixed * Tweak - Generate a link to preview and button at top of header * Tweak - Extra checks for addons emails * Fix - Selected email template not parsing issue due to extra parameter passed to function --------- Co-authored-by: Prajjwal <iamprazol@gmail.com> Co-authored-by: Salim Shrestha <salimshrestha98@gmail.com> Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com> Co-authored-by: Milan Chaudhary <chaudharymilan996@gmail.com> commit 9af1c7b Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Mon Aug 7 17:14:46 2023 +0545 UR-1116 Fix - Lost Password not working for translated myaccount page. (#586) * Fix - Lost Password Translation issue * Fix - Check current page id while reset password --------- Co-authored-by: Milan Chaudhary <chaudharymilan996@gmail.com> commit d5d4a9a Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Mon Aug 7 09:58:04 2023 +0545 Fix - Conflict with TranslatePress (#587) commit c85f08f Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Fri Aug 4 10:37:32 2023 +0545 Fix - Compatibility with all editors (#579) commit 1405c06 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Fri Aug 4 10:33:46 2023 +0545 Enhancement - Unique id smart tag (#584) * Add - Unique id smart tag * Add - Filter to change unique id prefix and entropy --------- Co-authored-by: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com> commit a3aa5e6 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Fri Aug 4 10:31:13 2023 +0545 Fix - add new form and click on scratch and enter any name and cancel the process the form will be created (#578) commit 8d98d6a Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Fri Aug 4 10:30:26 2023 +0545 Fix - Registration and login page redirection after revisiting these page (#581) commit afe86fa Author: Lekhnath Pandey <lekhnath005@gmail.com> Date: Thu Aug 3 18:14:30 2023 +0545 Dev - Add Extra parameter in the filter hook user_registration_before_insert_user commit 076cd60 Author: Lekhnath Pandey <lekhnath005@gmail.com> Date: Thu Aug 3 18:08:52 2023 +0545 Fix - Check null for file_exits function commit 0d753a2 Author: Milan Chaudhary <chaudharymilan996@gmail.com> Date: Wed Aug 2 12:28:24 2023 +0545 Fix - Input box highlighting border color commit 50d9d06 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Wed Aug 2 11:49:27 2023 +0545 Tweak - Input box highlighting (#582) commit 20c6d59 Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Wed Aug 2 10:52:10 2023 +0545 Enhance - User Registered Language with Smart Tag (#585) commit 42b4efc Merge: cb29f48 45ca49d Author: Lekhnath Pandey <lekhnath005@gmail.com> Date: Wed Jul 19 14:17:49 2023 +0545 Merge master into develop branch commit cb29f48 Author: Lekhnath Pandey <lekhnath005@gmail.com> Date: Tue Jul 18 17:41:42 2023 +0545 Fix - Typecasting issue in myaccount tag state commit c193a7b Author: Lekhnath Pandey <lekhnath005@gmail.com> Date: Wed Jul 12 15:01:22 2023 +0545 Dev - Add filter to modify smart tag content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Previously, We were using preg match to find shortcode in the post content but by doing that not all editors was compatible such as oxygen editor. This oxygen editor is not saving data in the post content it saves in the post meta table. This PR will make all editors compatible.
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry