-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UR-821 Dev - Compatibility for enabling/disabling taking picture from the webcam. #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipuchaudhary
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
MILAN88888
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
lekhnath005
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
lekhnath005
added
Approved
Ready to Merge
Tested
and removed
Needs Review
Needs Tests
labels
Aug 30, 2023
iamprazol
added a commit
that referenced
this pull request
Aug 31, 2023
Squashed commit of the following: commit 7d40eaa Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 16:28:46 2023 +0545 Feature - Cloudflare turnstile captcha integration (#596) commit 7eda608 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 16:28:32 2023 +0545 UR-1130 Fix - Incorrect filtering of pending users (#597) * Fix - User pending notice showing same number after denying users * Fix - Pending notice not showing * Fix - Pending filter showing denied users * Enhance - Add filter for Email Pending users * Fix - Denied users filter not working commit 21eba06 Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com> Date: Wed Aug 30 16:28:03 2023 +0545 Enhance - Option Enable/Disable taking picture from webcam (#592) commit 3e568a8 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Wed Aug 30 13:02:04 2023 +0545 Enhancement - Create a menu to show the login form shortcode (#583) * Add - Login Forms tab * Fix - Login tabs list * Fix - Url issue * login shortcode page design fix * Add - Div wrapper * login shortcode design fix * login shortcode design fix * Added - Default active tab, notices area, copy icon * Add - Login Wrapper * login shortcode and form builder design fix * Fixed - Copy shortcode tooltips message, login form content --------- Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com> commit a25272b Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 11:50:14 2023 +0545 UR-818 Fix - Submitting issue for conditionally hidden fields (#589) * Fix - Submitting conditionally hidden fields * Code cleanup * Fix - conditionally hidden value submitting on hide/show multiple conditions commit d0cb5c8 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 10:47:32 2023 +0545 UR-1052 Enhance - Custom hold time before redirection after registration (#593) * Feature - Custom Hold period before redirection * Fix - Prevent negative input for wait time commit c04ec96 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Tue Aug 29 14:43:52 2023 +0545 Dev - Add filter to show extra user details to non admin commit f672b89 Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Tue Aug 29 14:35:53 2023 +0545 UR-573 Feature - Pattern validation for input fields (#588) * Added - Dependency of pattern validation * Toggle pattern option when enabled * Fix - concatenation of regex value * Fix - html element appending while selecting regex value commit fff9803 Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Tue Aug 29 13:27:54 2023 +0545 UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591) * Fix - Invalid myaccount link while lost-password, logout, etc. * Fix - Email not been sent * Fix - Reset Password link throws invalid key commit ccc5c2a Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Mon Aug 28 12:37:43 2023 +0545 UR-903 Tweak - Revamp deactivation pop items (#594) * Tweak - Revamp deactivation pop items * Open links in new tab commit be73576 Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:16:33 2023 +0545 UR-1021 Fix - Other plugin notice displaying in our settings area commit c64f8fc Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:14:32 2023 +0545 UR-1127 Tweak - Corrected typos with addons url in readmeSquashed commit of the following: commit 7d40eaa Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 16:28:46 2023 +0545 Feature - Cloudflare turnstile captcha integration (#596) commit 7eda608 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 16:28:32 2023 +0545 UR-1130 Fix - Incorrect filtering of pending users (#597) * Fix - User pending notice showing same number after denying users * Fix - Pending notice not showing * Fix - Pending filter showing denied users * Enhance - Add filter for Email Pending users * Fix - Denied users filter not working commit 21eba06 Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com> Date: Wed Aug 30 16:28:03 2023 +0545 Enhance - Option Enable/Disable taking picture from webcam (#592) commit 3e568a8 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Wed Aug 30 13:02:04 2023 +0545 Enhancement - Create a menu to show the login form shortcode (#583) * Add - Login Forms tab * Fix - Login tabs list * Fix - Url issue * login shortcode page design fix * Add - Div wrapper * login shortcode design fix * login shortcode design fix * Added - Default active tab, notices area, copy icon * Add - Login Wrapper * login shortcode and form builder design fix * Fixed - Copy shortcode tooltips message, login form content --------- Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com> commit a25272b Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 11:50:14 2023 +0545 UR-818 Fix - Submitting issue for conditionally hidden fields (#589) * Fix - Submitting conditionally hidden fields * Code cleanup * Fix - conditionally hidden value submitting on hide/show multiple conditions commit d0cb5c8 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 10:47:32 2023 +0545 UR-1052 Enhance - Custom hold time before redirection after registration (#593) * Feature - Custom Hold period before redirection * Fix - Prevent negative input for wait time commit c04ec96 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Tue Aug 29 14:43:52 2023 +0545 Dev - Add filter to show extra user details to non admin commit f672b89 Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Tue Aug 29 14:35:53 2023 +0545 UR-573 Feature - Pattern validation for input fields (#588) * Added - Dependency of pattern validation * Toggle pattern option when enabled * Fix - concatenation of regex value * Fix - html element appending while selecting regex value commit fff9803 Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Tue Aug 29 13:27:54 2023 +0545 UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591) * Fix - Invalid myaccount link while lost-password, logout, etc. * Fix - Email not been sent * Fix - Reset Password link throws invalid key commit ccc5c2a Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Mon Aug 28 12:37:43 2023 +0545 UR-903 Tweak - Revamp deactivation pop items (#594) * Tweak - Revamp deactivation pop items * Open links in new tab commit be73576 Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:16:33 2023 +0545 UR-1021 Fix - Other plugin notice displaying in our settings area commit c64f8fc Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:14:32 2023 +0545 UR-1127 Tweak - Corrected typos with addons url in readme
iamprazol
added a commit
that referenced
this pull request
Aug 31, 2023
Squashed commit of the following: commit 7d40eaa Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 16:28:46 2023 +0545 Feature - Cloudflare turnstile captcha integration (#596) commit 7eda608 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 16:28:32 2023 +0545 UR-1130 Fix - Incorrect filtering of pending users (#597) * Fix - User pending notice showing same number after denying users * Fix - Pending notice not showing * Fix - Pending filter showing denied users * Enhance - Add filter for Email Pending users * Fix - Denied users filter not working commit 21eba06 Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com> Date: Wed Aug 30 16:28:03 2023 +0545 Enhance - Option Enable/Disable taking picture from webcam (#592) commit 3e568a8 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Wed Aug 30 13:02:04 2023 +0545 Enhancement - Create a menu to show the login form shortcode (#583) * Add - Login Forms tab * Fix - Login tabs list * Fix - Url issue * login shortcode page design fix * Add - Div wrapper * login shortcode design fix * login shortcode design fix * Added - Default active tab, notices area, copy icon * Add - Login Wrapper * login shortcode and form builder design fix * Fixed - Copy shortcode tooltips message, login form content --------- Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com> commit a25272b Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 11:50:14 2023 +0545 UR-818 Fix - Submitting issue for conditionally hidden fields (#589) * Fix - Submitting conditionally hidden fields * Code cleanup * Fix - conditionally hidden value submitting on hide/show multiple conditions commit d0cb5c8 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 10:47:32 2023 +0545 UR-1052 Enhance - Custom hold time before redirection after registration (#593) * Feature - Custom Hold period before redirection * Fix - Prevent negative input for wait time commit c04ec96 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Tue Aug 29 14:43:52 2023 +0545 Dev - Add filter to show extra user details to non admin commit f672b89 Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Tue Aug 29 14:35:53 2023 +0545 UR-573 Feature - Pattern validation for input fields (#588) * Added - Dependency of pattern validation * Toggle pattern option when enabled * Fix - concatenation of regex value * Fix - html element appending while selecting regex value commit fff9803 Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Tue Aug 29 13:27:54 2023 +0545 UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591) * Fix - Invalid myaccount link while lost-password, logout, etc. * Fix - Email not been sent * Fix - Reset Password link throws invalid key commit ccc5c2a Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Mon Aug 28 12:37:43 2023 +0545 UR-903 Tweak - Revamp deactivation pop items (#594) * Tweak - Revamp deactivation pop items * Open links in new tab commit be73576 Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:16:33 2023 +0545 UR-1021 Fix - Other plugin notice displaying in our settings area commit c64f8fc Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:14:32 2023 +0545 UR-1127 Tweak - Corrected typos with addons url in readmeSquashed commit of the following: commit 7d40eaa Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 16:28:46 2023 +0545 Feature - Cloudflare turnstile captcha integration (#596) commit 7eda608 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 16:28:32 2023 +0545 UR-1130 Fix - Incorrect filtering of pending users (#597) * Fix - User pending notice showing same number after denying users * Fix - Pending notice not showing * Fix - Pending filter showing denied users * Enhance - Add filter for Email Pending users * Fix - Denied users filter not working commit 21eba06 Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com> Date: Wed Aug 30 16:28:03 2023 +0545 Enhance - Option Enable/Disable taking picture from webcam (#592) commit 3e568a8 Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com> Date: Wed Aug 30 13:02:04 2023 +0545 Enhancement - Create a menu to show the login form shortcode (#583) * Add - Login Forms tab * Fix - Login tabs list * Fix - Url issue * login shortcode page design fix * Add - Div wrapper * login shortcode design fix * login shortcode design fix * Added - Default active tab, notices area, copy icon * Add - Login Wrapper * login shortcode and form builder design fix * Fixed - Copy shortcode tooltips message, login form content --------- Co-authored-by: Ayush Shrestha <ayushstha143@gmail.com> commit a25272b Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Wed Aug 30 11:50:14 2023 +0545 UR-818 Fix - Submitting issue for conditionally hidden fields (#589) * Fix - Submitting conditionally hidden fields * Code cleanup * Fix - conditionally hidden value submitting on hide/show multiple conditions commit d0cb5c8 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Wed Aug 30 10:47:32 2023 +0545 UR-1052 Enhance - Custom hold time before redirection after registration (#593) * Feature - Custom Hold period before redirection * Fix - Prevent negative input for wait time commit c04ec96 Author: Salim Shrestha <salimshrestha98@gmail.com> Date: Tue Aug 29 14:43:52 2023 +0545 Dev - Add filter to show extra user details to non admin commit f672b89 Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Tue Aug 29 14:35:53 2023 +0545 UR-573 Feature - Pattern validation for input fields (#588) * Added - Dependency of pattern validation * Toggle pattern option when enabled * Fix - concatenation of regex value * Fix - html element appending while selecting regex value commit fff9803 Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com> Date: Tue Aug 29 13:27:54 2023 +0545 UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591) * Fix - Invalid myaccount link while lost-password, logout, etc. * Fix - Email not been sent * Fix - Reset Password link throws invalid key commit ccc5c2a Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com> Date: Mon Aug 28 12:37:43 2023 +0545 UR-903 Tweak - Revamp deactivation pop items (#594) * Tweak - Revamp deactivation pop items * Open links in new tab commit be73576 Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:16:33 2023 +0545 UR-1021 Fix - Other plugin notice displaying in our settings area commit c64f8fc Author: Prajjwal Poudel <iamprazol@gmail.com> Date: Wed Aug 23 10:14:32 2023 +0545 UR-1127 Tweak - Corrected typos with addons url in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR provides compatibility for enabling/disabling taking picture from webcam in the profile picture field.
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry