Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - UR form fields integration on woo commerce product page. #606

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Feature - UR form fields integration on woo commerce product page. #606

merged 1 commit into from
Oct 6, 2023

Conversation

MILAN88888
Copy link
Contributor

@MILAN88888 MILAN88888 commented Sep 21, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR introduces a new feature where users can sync the user registration form field on the wocommerence product page which is used to collect the extra information of the product.

Depend PR:

  1. User registration woocommerce ( Form validation) -> https://github.com/wpeverest/user-registration-woocommerce/pull/33
  2. Conditional logic (Conditional logic compatible) -> https://github.com/wpeverest/user-registration-conditional-logic/pull/32

How to test the changes in this Pull Request:

  1. I have mentioned on the card. Please follow the link https://themegrill.atlassian.net/browse/UR-986

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Feature - UR form fields integration on woo commerce product page.

@MILAN88888 MILAN88888 self-assigned this Sep 21, 2023
@iamprazol iamprazol requested review from bishal-karki and removed request for deepench, dipuchaudhary and bishal-karki September 28, 2023 09:03
lekhnath005
lekhnath005 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@lekhnath005 lekhnath005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

iamprazol
iamprazol approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@iamprazol iamprazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

salimshrestha98
salimshrestha98 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@salimshrestha98 salimshrestha98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

@iamprazol iamprazol removed the request for review from Sanjuacharya October 6, 2023 05:03
@iamprazol iamprazol merged commit e04db78 into develop Oct 6, 2023
1 check passed
@iamprazol iamprazol deleted the UR-986-feature/woo-commerce-integration branch October 6, 2023 05:03
iamprazol added a commit that referenced this pull request Oct 9, 2023
@iamprazol
Squashed commit of the following:
98cc1b2 
commit 25d9a0b
Author: Prajjwal Poudel <iamprazol@gmail.com>
Date:   Mon Oct 9 08:11:58 2023 +0545

    Fix - Critical error due to wrong indentation

commit b7d6ef3
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Mon Oct 9 07:15:27 2023 +0545

    UR-1200 Feature - Admin image uploader module (#608)

    * Enhance - User registration Conversational Forms dependency

    * Dev - Add wrapper for buttons

    * Fix - Uploaded image hide/show issue

commit baf30eb
Author: Lekhnath Pandey <46083608+lekhnath005@users.noreply.github.com>
Date:   Fri Oct 6 12:07:59 2023 +0545

    Enhance - Display Fatal errors in logs (#611)

commit e04db78
Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com>
Date:   Fri Oct 6 10:48:36 2023 +0545

    Added - Form validaton compatible (#606)

commit f89b9e6
Author: Prajjwal Poudel <iamprazol@gmail.com>
Date:   Fri Oct 6 10:45:25 2023 +0545

    UR-1220 Tweak - Urls in readme txt

commit 443270b
Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com>
Date:   Thu Oct 5 16:58:02 2023 +0545

    Tweak -  Save the user IP on the user meta. (#609)

    * Added - User Ip in user meta

    * Added - Update user ip while updating profile

    * Removed - Unwanted code

    ---------

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

commit 86c8d1b
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Thu Oct 5 16:54:11 2023 +0545

    UR-749 Dev - Merge two duplicate methods on form validation (#590)

    * Dev - Merge two duplicate validation methods for update profile

    * Update sync branch

    * Dev - Add skippable fields on update validation

    * Tweak - Remove unnecessary function

commit 1a26ec2
Author: Ranjan Khanal <83644457+zhea-son@users.noreply.github.com>
Date:   Thu Oct 5 11:20:44 2023 +0545

    send user approval link in email to admin using send email option enable/disable (#610)

commit e17ea74
Author: Prajjwal Poudel <iamprazol@gmail.com>
Date:   Thu Oct 5 11:00:05 2023 +0545

    UR-1066 Dev - Compatibility for custom user listings

commit f906257
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Thu Oct 5 08:55:18 2023 +0545

    UR-1139 Refactor - Handle user status properly (#595)

    * Fix - User pending notice showing same number after denying users

    * Fix - Pending notice not showing

    * Fix - Pending filter showing denied users

    * Refactor - Get user login option from user meta

    Instead of handling user with the login option set in form settings in present, user must be handled according to the login option set during the time of registration.

    * Add - is_email_pending function

    * Tweak - Check function exists

    * Refactor - Add email pending label

    * Dev - Update sync parameters

    * Fix - User not being denied

    * Fix - Denied filter not working

    * Remove sync code

    ---------

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

commit fa8a128
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Thu Oct 5 08:46:40 2023 +0545

    UR-1049 profile details updated email to user (#603)

    * Feature - Send email to user after profile details update

    * Tweak - Priority order of send profile changed email

    * Fix - Privacy field value

    * Dynamic email translation added

commit a526dfe
Author: Ranjan Khanal <83644457+zhea-son@users.noreply.github.com>
Date:   Thu Oct 5 08:46:12 2023 +0545

    Fix - Collapse issue (#607)

commit 4451cb6
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Wed Oct 4 19:07:06 2023 +0545

    UR-870 Enhance - Test captcha from settings (#601)

    * Feature - Test captcha from captcha settings

    * Add - Cloudflare turnstile

    * Enhance - Notice messages

    * Enhance - Make strings translatable

    * Fix - Hide test captcha button on changes

    * Tweak - Hide cloudflare turnstile test wrapper when Theme of cloudflare changed

    ---------

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

commit 84927fb
Author: Milan Chaudhary <chaudharymilan996@gmail.com>
Date:   Wed Oct 4 17:07:54 2023 +0545

    Fix - Missing closing tag

commit f8f1b5f
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Wed Oct 4 08:29:19 2023 +0545

    UR-1035 Compatibility custom captcha (#604)

    * Dependency of custom captcha field

    * Custom captcha field icon added

    * Unset captcha field form edit profile

    * Dev - Captcha dependency moved to pro

    * Code cleanup

    * Updated

commit 7409448
Author: Milan Chaudhary <109399375+MILAN88888@users.noreply.github.com>
Date:   Wed Oct 4 08:24:07 2023 +0545

    Tweak - Redirect url as slug in login and my account shortcode (#599)

    * Tweak - Redirection even if the redirect_url is page slug

    * Added - Redirection even if we put the slug as redirect_url in login shortcode

    * Fixed - The case if no valid url and page slug then redirect to home url

    ---------

    Co-authored-by: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>

commit 995ba2b
Author: deepench <elendoff11@gmail.com>
Date:   Tue Oct 3 12:20:08 2023 +0545

    Added - WPML compatibilty for validation message for duplicate

commit 4490a54
Author: Prajjwal Poudel <iamprazol@gmail.com>
Date:   Tue Oct 3 11:40:11 2023 +0545

    Fix - Typo

commit 56bfe9c
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Tue Oct 3 11:27:28 2023 +0545

    UR-576 Fix - Select All button not working in Nav Menus (#598)

    * Fix - Select All btn not working in Nav Menus

    * Fix - Translation

commit 0aee447
Author: Milan Chaudhary <chaudharymilan996@gmail.com>
Date:   Mon Oct 2 16:05:42 2023 +0545

    Fix - Grammatical typo for unique validation

commit 67b1296
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Mon Oct 2 08:00:43 2023 +0545

    UR-1059 Enhance - Links in admin bar menu (#602)

    * Enhance - Add Edit Form and New form links in admin bar menu

    * Tweak - Create new menu for UR items

    * Tweak - Translatable text wrapper missing

    ---------

    Co-authored-by: Prajjwal Poudel <iamprazol@gmail.com>

commit 67ec5a4
Author: Prajjwal Poudel <85762481+iamprazol@users.noreply.github.com>
Date:   Mon Oct 2 07:59:46 2023 +0545

    Tweak - Addons content made concrete and design to make it fit (#605)

commit d1eac11
Author: Dipu chaudhary <34309829+dipuchaudhary@users.noreply.github.com>
Date:   Mon Oct 2 07:54:05 2023 +0545

    jQuery validation library updated to 1.19.5 (#612)

commit 92ffda7
Author: Deependra Chaudhary <elendoff11@gmail.com>
Date:   Mon Oct 2 07:52:36 2023 +0545

    Fix - Escaping issue in redirect url (#613)

commit 0f3a77d
Author: Milan Chaudhary <chaudharymilan996@gmail.com>
Date:   Tue Sep 26 16:52:01 2023 +0545

    Fixed - Locked field pop issue

commit 937ed20
Author: Salim Shrestha <salimshrestha98@gmail.com>
Date:   Thu Sep 21 12:14:04 2023 +0545

    Fix - Send password reset not working on prevent core login

commit 1f7dffa
Author: Lekhnath Pandey <lekhnath005@gmail.com>
Date:   Wed Sep 13 13:19:14 2023 +0545

    Dev - Introduced new hooks to modify email header

commit f94a8bd
Author: Lekhnath Pandey <lekhnath005@gmail.com>
Date:   Thu Sep 7 12:47:27 2023 +0545

    Fix - Admin email not been delivered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimshrestha98 salimshrestha98 salimshrestha98 approved these changes

@lekhnath005 lekhnath005 lekhnath005 approved these changes

@iamprazol iamprazol iamprazol approved these changes

Assignees

@MILAN88888 MILAN88888

Labels
Approved Feature Request Merged Needs Documentation Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MILAN88888 @salimshrestha98 @lekhnath005 @iamprazol