Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning should be done on Git tag #437

Open
Daltz333 opened this issue Oct 9, 2020 · 7 comments
Open

Versioning should be done on Git tag #437

Daltz333 opened this issue Oct 9, 2020 · 7 comments

Comments

@Daltz333
Copy link
Member

Daltz333 commented Oct 9, 2020

Do not hardcode, but use git tags

@Starlight220
Copy link
Member

I think the version might need to be hardcoded (or at least accessible from plugin code) for release. Unless maybe we hardcode to gradle.properties (#429 ) and publish in CI.

@Starlight220
Copy link
Member

@ThadHouse do you think that it's realistic/practical to publish via CI that hardcodes the latest git tag to gradle.properties?

@Starlight220
Copy link
Member

Hasn't this been handled by #444?

@Daltz333
Copy link
Member Author

yes

@AustinShalit
Copy link
Member

Not yet. We still need to make a commit to update the version manually.

https://github.com/wpilibsuite/GradleRIO/blob/master/gradle.properties#L1

@AustinShalit AustinShalit reopened this Nov 21, 2020
@Starlight220
Copy link
Member

A commit editing gradle.properties will be needed anyway. The trick is that we might be able to have the commit done by GH Actions, though then the tag will be on the prior commit.
We can have a manually-triggered workflow that commits the version change and tags that commit.

@prateekma
Copy link
Member

prateekma commented Nov 22, 2020

We can get the version number from the latest tag so bumping the gradle.properties manually or automatically isn't required.

All of the tools and allwpilib do this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants