-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning should be done on Git tag #437
Comments
I think the version might need to be hardcoded (or at least accessible from plugin code) for release. Unless maybe we hardcode to |
@ThadHouse do you think that it's realistic/practical to publish via CI that hardcodes the latest git tag to |
Hasn't this been handled by #444? |
yes |
Not yet. We still need to make a commit to update the version manually. https://github.com/wpilibsuite/GradleRIO/blob/master/gradle.properties#L1 |
A commit editing |
We can get the version number from the latest tag so bumping the gradle.properties manually or automatically isn't required. All of the tools and allwpilib do this already. |
Do not hardcode, but use git tags
The text was updated successfully, but these errors were encountered: