Skip to content

Commit

Permalink
[sysid] Remove unused dependency on libglassnt (#7200)
Browse files Browse the repository at this point in the history
Also remove stale libuv references.
  • Loading branch information
Gold856 authored Oct 12, 2024
1 parent 7ebd45e commit f23bece
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
4 changes: 2 additions & 2 deletions sysid/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ endif()
wpilib_link_macos_gui(sysid)
wpilib_target_warnings(sysid)
target_include_directories(sysid PRIVATE src/main/native/include)
target_link_libraries(sysid wpimath libglassnt libglass)
target_link_libraries(sysid wpimath libglass)

if(WIN32)
set_target_properties(sysid PROPERTIES WIN32_EXECUTABLE YES)
Expand All @@ -42,5 +42,5 @@ if(WITH_TESTS)
target_compile_options(sysid_test PRIVATE /utf-8)
endif()
target_include_directories(sysid_test PRIVATE src/main/native/cpp src/main/native/include)
target_link_libraries(sysid_test wpimath libglassnt libglass googletest)
target_link_libraries(sysid_test wpimath libglass googletest)
endif()
6 changes: 0 additions & 6 deletions sysid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,7 @@ model {
it.buildable = false
return
}
lib project: ':glass', library: 'glassnt', linkage: 'static'
lib project: ':glass', library: 'glass', linkage: 'static'
project(':ntcore').addNtcoreDependency(it, 'static')
lib project: ':wpinet', library: 'wpinet', linkage: 'static'
lib project: ':wpimath', library: 'wpimath', linkage: 'static'
lib project: ':wpiutil', library: 'wpiutil', linkage: 'static'
lib project: ':wpigui', library: 'wpigui', linkage: 'static'
Expand Down Expand Up @@ -138,10 +135,7 @@ model {
it.buildable = false
return
}
lib project: ':glass', library: 'glassnt', linkage: 'static'
lib project: ':glass', library: 'glass', linkage: 'static'
project(':ntcore').addNtcoreDependency(it, 'static')
lib project: ':wpinet', library: 'wpinet', linkage: 'static'
lib project: ':wpimath', library: 'wpimath', linkage: 'static'
lib project: ':wpiutil', library: 'wpiutil', linkage: 'static'
lib project: ':wpigui', library: 'wpigui', linkage: 'static'
Expand Down
3 changes: 0 additions & 3 deletions sysid/src/main/native/cpp/App.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <glass/WindowManager.h>
#include <glass/other/Log.h>
#include <imgui.h>
#include <uv.h>
#include <wpi/Logger.h>
#include <wpi/print.h>
#include <wpigui.h>
Expand Down Expand Up @@ -96,8 +95,6 @@ void Application(std::string_view saveDir) {
});

gLogger.set_min_level(wpi::WPI_LOG_DEBUG);
// Set the number of workers for the libuv threadpool.
uv_os_setenv("UV_THREADPOOL_SIZE", "6");

// Initialize window manager and add views.
auto& storage = glass::GetStorageRoot().GetChild("SysId");
Expand Down

0 comments on commit f23bece

Please sign in to comment.