Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp cmd] Fix SelectCommand multiple composition bug #5569

Closed
wants to merge 1 commit into from

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Aug 25, 2023

No description provided.

@rzblue rzblue requested a review from a team as a code owner August 25, 2023 22:12
@rzblue rzblue added the component: command-based WPILib Command Based Library label Aug 25, 2023
@rzblue rzblue changed the title Fix SelectCommand multiple composition bug [cpp cmd] Fix SelectCommand multiple composition bug Aug 25, 2023
@Starlight220
Copy link
Member

Can you add a test?
Also, is Java correct?

@rzblue
Copy link
Member Author

rzblue commented Aug 26, 2023

Yep, java is correct.

Should we add tests for all commands to ensure that they are handling inner commands properly?

@rzblue
Copy link
Member Author

rzblue commented Aug 26, 2023

Merged with #5571

@rzblue rzblue closed this Aug 26, 2023
@rzblue rzblue deleted the selectcmd-setcomposed branch August 30, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: command-based WPILib Command Based Library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants