[cpp cmd] Fix leakage and multiple composition bug in SelectCommand #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzblue
force-pushed
the
selectcmd-leakage
branch
from
556ae5c
to
21332b4
Compare
rzblue
force-pushed
the
selectcmd-leakage
branch
from
61eee02
to
7fbc4d8
Compare
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java
Outdated
Show resolved
Hide resolved
rzblue
changed the title
|
Merging with #5569 to avoid conflicts |
|
(Continuing my review from the other PR)
That's not a bad idea, and can be done easily by adding to the As long as there aren't active changes to tests specific to other classes, I'd consider it in scope. |
|
#5581 adds tests for this in java. I'm not sure how to test the behavior in c++, since ownership semantics largely prevent users from doubly composing commands. I'd rather stick the tests in that PR, since it's already touching a bunch of files. |
Starlight220
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.