Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add warning about using user button to docs (NFC) #6129

Merged
merged 3 commits into from
Jan 1, 2024
Merged

[Doc] Add warning about using user button to docs (NFC) #6129

merged 3 commits into from
Jan 1, 2024

Conversation

sciencewhiz
Copy link
Contributor

Fixes #5165

@sciencewhiz sciencewhiz requested review from a team as code owners January 1, 2024 05:03
@Starlight220
Copy link
Member

Maybe also ReportWarning() (like we do for I2C)? API docs are important, but they can be missed.

@sciencewhiz
Copy link
Contributor Author

I think the use of this is rare enough that it doesn't need a DS warning.

@sciencewhiz
Copy link
Contributor Author

Now if there was a way to make the image send a DS warning when it's turns on no-app, that would be useful

@ThadHouse
Copy link
Member

The DS log does actually say this year when the mode is switched.

@PeterJohnson PeterJohnson merged commit 7d3e4dd into wpilibsuite:main Jan 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning to getUserButton that it can break deploys
5 participants
@sciencewhiz @Starlight220 @ThadHouse @PeterJohnson @KangarooKoala