Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Glass/simgui] 2024 field image is not positioned correctly for coordinate system #6177

Closed
shueja opened this issue Jan 8, 2024 · 4 comments · Fixed by #6179
Closed

[Glass/simgui] 2024 field image is not positioned correctly for coordinate system #6177

shueja opened this issue Jan 8, 2024 · 4 comments · Fixed by #6179

Comments

@shueja
Copy link
Contributor

shueja commented Jan 8, 2024

Describe the bug
image
Also, the field dimensions show as 2023's dimensions when 2024 is selected
To Reproduce

  • Open a field visualization in Glass or SimGui (this probably requires making a robot project with a Field2d published)
  • Set the image to 2024.
sciencewhiz added a commit to Beachbot330/allwpilib that referenced this issue Jan 9, 2024
@sciencewhiz
Fix 2024 field json
e93c317 
field corners and field size were identical to 2023
Fixes wpilibsuite#6177
@sciencewhiz sciencewhiz mentioned this issue Jan 9, 2024
Merged
@sciencewhiz
Copy link
Contributor

Reopening because with #6179 it looks like the robot still isn't placed correctly

image

@sciencewhiz sciencewhiz reopened this Jan 9, 2024
@jasondaming
Copy link
Member

Is there a way to change this locally until this change gets pushed?

@sciencewhiz
Copy link
Contributor

There's two issues. There's problems with the field border in the 2024 json file. #6185 fixes that. There also appears to be a bug in the glass scaling code that is yet unfound. So while you could use the files in #6185 locally for pathweaver, it will still have problems with glass.

@sciencewhiz
Copy link
Contributor

The combination of #6185 and #6222 fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 2024 field json Beachbot330/allwpilib
3 participants
@sciencewhiz @jasondaming @shueja